Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master #13

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Master #13

wants to merge 3 commits into from

Conversation

INam1995
Copy link

Styling of login page is fixed and now it is responsive .

i have made the page responsive by adding two media queries(1048 and 884 (one is given there already) ) changed background image , fixed minor styling issues , linked login.css , partial.css and login.js files properly with login.html file , linked properly signup right image and sign in left image , changed fonts style , fonts weight and improved overall appearance of the login page

Type of change

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [x ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Motivation and Context

for better user experience and better appearance of login page in any view(like at mobile phone , at desktop ) i have required some styling changes and this problem solved the appearance of login page and responsiveness of the login page at any device.

How Has This Been Tested?

by opening live server and for media queries i inspected the web page and then check it.

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Screenshots (if appropriate):

https://drive.google.com/drive/folders/1IMdc7D9AHNHB2y6hd_IEWV8-I_iIqCVr?usp=sharing

Checklist:

  • [ x] I have registered myself at Contrihub website.
  • [ x] My code follows the code style of this project.
  • I have commented my code, particularly in hard-to-understand areas
  • [x ] My changes generate no new warnings
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [ x] I have read the CONTRIBUTING document.
  • [ x] Any dependent changes have been merged and published in downstream modules
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@INam1995 INam1995 mentioned this pull request Oct 16, 2023
14 tasks
@dhanrajchaurasia
Copy link
Collaborator

You shouldn't change the colors of the login/signup card just fix the stylings (indentation, fontsize.etc) also make it responsive. I have seen the shared screenshots but they're not what I was expecting so just fix margin, spacing.etc and other styling mentioned above. Also in responsiveness, it should not switch between signup-login like that though it should get replaced completely to the other form (login becomes signup and signup becomes login) without the side banner/image in the responsive styling (for mobile devices).

@INam1995
Copy link
Author

INam1995 commented Oct 27, 2023 via email

@dhanrajchaurasia
Copy link
Collaborator

dhanrajchaurasia commented Oct 28, 2023

@INam1995
yes! make an assignment request first!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants